Re: Question about Old Fix Me comment in mempool.c

From: Mikulas Patocka
Date: Wed Feb 25 2015 - 15:18:58 EST




On Tue, 16 Dec 2014, nick wrote:

> Greetings Andrew and other maintainers,
> I am wondering why the below comment is even in mempool.c and this has not been changed to a call to io_schedule as the kernel version is stupidly old and this should be fixed by now and the issues with DM would have been removed by now.
> /*
> * FIXME: this should be io_schedule(). The timeout is there as a
> * workaround for some DM problems in 2.6.18.
> */
>
> Sorry for the stupid question but I like to double check with the maintainers before I sent in a patch for things like this to see if I am missing anything:).
>
> Thanks for Your Time,
> Nick

There are still some bugs with respect to this (and they will probably
never be removed all) - for example this bug which wasn't fixed yet
http://www.redhat.com/archives/dm-devel/2014-May/msg00089.html .

So, you should not remove it.

Mikulas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/