Re: [PATCH 1/1] serial: 8250_dw: Fix get_mctrl behaviour

[Jonathan Richardson]

Hi Arnd,

On 15-02-25 11:21 AM, Arnd Bergmann wrote:
> On Wednesday 25 February 2015 11:04:16 Jonathan Richardson wrote:
>> +- msr-override : array of strings to be used to override the individual
>> +  modem status signals for DCD, DSR, CTS, and RI.  If the property is not
>> +  present, the individual signals are obtained from the modem status register.
>> +  Strings accepted are "dcd", "dsr", "cts", and "ri". If "dcd", "dsr", or
>> +  "cts" are present, these signals will always be reported as active. If
>> +  "ri" is present, this signal will always be reported as inactive.
>>
> 
> Did you copy this definition from another driver? If not, we should try
> to come up with a more natural way to do it. How about defining four
> boolean properties instead, like
> 
> 	dcd-override
> 	dsr-override
> 	cts-override
> 	ri-override
> 
> Simplifies the parser and the binding.

I didn't see anything similar in another driver. I agree with the bools
instead of strings. Did you want to keep these in the Synopsis driver
for now or were you thinking of putting them somewhere that they could
be re-used?

Thanks.

> 
> 	Arnd
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/