Re: [PATCH 3/3] HID: rmi: disable palm detect gesture when present

From: Jiri Kosina
Date: Wed Feb 25 2015 - 09:35:52 EST


On Wed, 25 Feb 2015, Gabriele Mazzotta wrote:

> On Tuesday 24 February 2015 17:36:50 Andrew Duggan wrote:
> > A touchpad may have firmware based palm detection code enabled which
> > suppresses 2D data from being reported when the firmware believes a palm is
> > on the touchpad. This functionality is meant to be used in mouse mode without
> > a driver. When a driver is present, the driver can do a better job of
> > determining if a contact is a palm. If this gesture is enabled on a touchpad
> > operating in rmi mode then the firmware will not properly clear the palm detect
> > interrupt, causing the touchpad to interrupt indefinately. This patch disables
> > the palm detect gesture when the touchpad is operating in rmi mode.
> >
> > Signed-off-by: Andrew Duggan <aduggan@xxxxxxxxxxxxx>
> > ---
> > Hi Gabriele,
> >
> > Can you test this patch on your system to confirm that it fixes your issue?
> > I was able to test the other two patches so I can confirm that the write
> > fuction works. But, I don't have a touchpad with the palm detect gesture
> > enabled so it would be good to double check that I have the right address and
> > mask.
> >
> > Andrew
>
> I tested it and confirm that it's working. Thanks.

Thanks for testing. I have now applied the series to for-4.1/rmi.

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/