Re: [PATCH 2/7] x86: entry.S: simplify optimistic SYSRET

[Denys Vlasenko]

On Wed, Feb 25, 2015 at 1:04 AM, Andy Lutomirski <luto@xxxxxxxxxxxxxx> wrote:
>> --- a/arch/x86/kernel/entry_64.S
>> +++ b/arch/x86/kernel/entry_64.S
>> @@ -756,9 +756,8 @@ retint_swapgs:              /* return to user-space */
>>          */
>>  irq_return_via_sysret:
>>         CFI_REMEMBER_STATE
>> -       RESTORE_C_REGS
>> -       REMOVE_PT_GPREGS_FROM_STACK 8
>> -       movq (RSP-RIP)(%rsp),%rsp
>> +       RESTORE_C_REGS_EXCEPT_R11
>> +       movq RSP(%rsp),%rsp
>
> I think this needs a comment.

I assume you mean "a comment why r11 doesn't need restoring".
I sent patch v2.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/