Re: [Xen-devel] [PATCH 05/13] xen: simplify xen_set_identity_and_remap() by using global variables

[Juergen Gross]

On 02/19/2015 07:10 PM, David Vrabel wrote:
> On 18/02/2015 06:51, Juergen Gross wrote:
> > xen_set_identity_and_remap() is used to prepare remapping of memory
> > conflicting with the E820 map. It is tracking the pfn where to remap
> > new memory via a local variable which is passed to a subfunction
> > which in turn returns the new value for that variable.
> >
> > Additionally the targeted maximum pfn is passed as a parameter to
> > sub functions.
> >
> > Simplify that construct by using just global variables in the
> > source for that purpose. This will make things simpler when we need
> > those values later, too.
>
> I'm not convinced this actually simplifies anything.

Perhaps I should have emphasised the last sentence a bit more. I really
need the global variables when deferring the remap operation.

Juergen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/