Re: [PATCH] kconfig: Use macros which are already defined

From: Michal Simek
Date: Mon Feb 23 2015 - 05:23:23 EST


Hi Andrew,

On 12/11/2014 10:00 AM, Michal Simek wrote:
> It is better to use macros which are already available
> because then there is just one location which needs to be change.
>
> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
> ---
>
> FYI: Fengguang's testing system doesn't show any build error.
> ---
> include/linux/kconfig.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/kconfig.h b/include/linux/kconfig.h
> index be342b94c640..71acdf650e2e 100644
> --- a/include/linux/kconfig.h
> +++ b/include/linux/kconfig.h
> @@ -28,7 +28,7 @@
> *
> */
> #define IS_ENABLED(option) \
> - (config_enabled(option) || config_enabled(option##_MODULE))
> + (IS_BUILTIN(option) || IS_MODULE(option))
>
> /*
> * IS_BUILTIN(CONFIG_FOO) evaluates to 1 if CONFIG_FOO is set to 'y', 0
> --
> 1.8.2.3
>

Can you please add this to your queue?

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


Attachment: signature.asc
Description: OpenPGP digital signature