Re: [Xen-devel] [PATCH 10/10] xen/blkfront: use work queue to fast blkif interrupt return

From: David Vrabel
Date: Thu Feb 19 2015 - 12:26:16 EST




On 15/02/2015 08:19, Bob Liu wrote:
Move the request complete logic out of blkif_interrupt() to a work queue,
after that we can replace 'spin_lock_irq' with 'spin_lock' so that irq won't
be disabled too long in blk_mq_queue_rq().

I think using a threaded interrupt (like scsifront) is better than work. Also, this seems orthogonal to the multiqueue support. Is it a useful bug fix on its own?

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/