Re: [PATCH] net: sched: One function call less in em_meta_change() after error detection

From: SF Markus Elfring
Date: Sat Jan 31 2015 - 16:53:29 EST


>> -errout:
>> - if (err && meta)
>> - meta_delete(meta);
>
> Since this patch seems to be about optimization and cleanup you should
> probably also remove the now unnecessary initialization of "meta" with
> NULL at the beginning of the function...

Will the optimiser of the C compiler drop any remaining unnecessary
variable initialisations?

Do you want another update step here?

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/