Re: [PATCH] ata: libahci: Use of_platform_device_create only if supported

[Guenter Roeck]

On 01/31/2015 08:45 AM, Tejun Heo wrote:
> On Sat, Jan 31, 2015 at 08:32:18AM -0800, Guenter Roeck wrote:
> > of_platform_device_create does not exist if OF_ADDRESS is not configured,
> > so limit its use accordingly.
> >
> > Without this fix, the sparc64:allmodconfig build fails with
> >
> > ERROR: "of_platform_device_create" [drivers/ata/libahci_platform.ko] undefined!
> >
> > Fixes: c7d7ddee7e24 ("ata: libahci: Allow using multiple regulators")
> > Cc: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > ---
> > Applies to -next.
> >
> >   drivers/ata/libahci_platform.c | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
> > index 077c7a2..de9a5dc 100644
> > --- a/drivers/ata/libahci_platform.c
> > +++ b/drivers/ata/libahci_platform.c
> > @@ -434,7 +434,8 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev)
> >   			}
> >   			mask_port_map |= BIT(port);
> >
> > -			of_platform_device_create(child, NULL, NULL);
> > +			if (IS_ENABLED(CONFIG_OF_ADDRESS))
> > +				of_platform_device_create(child, NULL, NULL);
>
> This is weird.  Please either define a proper dummy version of the
> function in the appropriate header file or take out the whole
> invocation section w/ #ifndef.  The above is a weird hybrid where both
> the declaration and the user here are doing things half-way.  Please
> don't do this in other places either.

I agree, it is weird, as is the whole "all API functions associated
with OF_ADDRESS are handled differently on sparc" thing. But that
is neither new nor something I can fix.

No problem, I'll resubmit with #ifndef.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/