Re: [PATCH 3/3] clk: remove clk-private.h

[Stephen Boyd]

On 01/30/15 13:25, Michael Turquette wrote:
> Private clock framework data structures should be private, surprisingly.
>
> Now that all platforms and drivers have been updated to remove static
> initializations of struct clk and struct clk_core objects and all
> references to clk-private.h have been removed we can move the
> definitions of these structures into drivers/clk/clk.c and delete the
> header.
>
> Additionally the ugly DEFINE_CLK macros have been removed. Those were
> used for static definitions of struct clk objects. That practice is no
> longer allowed.
>
> Signed-off-by: Michael Turquette <mturquette@xxxxxxxxxx>

This is great!

Reviewed-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>

given the minor comment below.

> - * Returns 0 on success, otherwise an error code.
> - */
> -int __clk_init(struct device *dev, struct clk *clk);

Shouldn't __clk_init become static now in clk.c?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/