Re: [PATCH 2/2] drm/msm/hdmi: add hdmi hdcp support (V2)

[Bjorn Andersson]

On Fri, Jan 30, 2015 at 1:51 PM, Bjorn Andersson <bjorn@xxxxxxx> wrote:
> On Tue, Jan 13, 2015 at 12:43 PM, Jilai Wang <jilaiw@xxxxxxxxxxxxxx> wrote:
>> Add HDMI HDCP support including HDCP PartI/II/III authentication.
>> V1: Initial Change
>> V2: Address Bjorn&Rob's comments
>>     Refactor the authentication process to use single work instead
>>     of multiple work for different authentication stages.
>>
> Looks cleaner and the SCM parts look good now.
>
> But the ddc communication still makes me wonder, see below.
>

Rob made me aware about the fact that the hdmi driver is both
implementing a driver for the i2c controller and now for the hdcp
client and hence doesn't have an i2c_client handle.

So unless this is redesigned to be split in a separate i2c client
driver we probably have to have the ddc functions like this.

I'm fine with this as is for now.

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/