Re: [PATCH] x86, mce: Always fall into mcelog path, regardless of what notifiers returned

From: Borislav Petkov
Date: Fri Jan 30 2015 - 12:38:52 EST


On Fri, Jan 30, 2015 at 09:29:47AM -0800, Tony Luck wrote:
> This has been broken for a while - but we should not allow code
> registered on the x86_mce_decoder_chain to bypass sending machine
> check logs to /dev/mcelog.
>
> Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx>
> ---
>
> Yes, we've had this conversation before and I wimped out and didn't
> push the issue. But userspace is broken. People are complaining to
> me that errors don't show up in /var/log/mcelog even though they
> started the mcelog(8) daemon.

We need to fix this differently - on AMD, mcelog is not needed as the
decoding is done in the kernel.

We could use mce_register_decode_chain() for callers to state what they
want.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/