Re: [PATCH 2/3] perf tools: Do not rely on dso__data_read_offset() to open dso

[Jiri Olsa]

On Fri, Jan 30, 2015 at 11:33:28AM +0900, Namhyung Kim wrote:
> Do not rely on dso__data_read_offset() will always call dso__data_fd()
> internally.  With multi-thread support, accessing a fd will be
> protected by a lock and it'll cause a huge contention.  It can be
> avoided since we can skip reading from file if there's a data in the
> dso cache.
> 
> If one needs to call the dso__data_read_offset(), [s]he also needs to
> call dso__data_fd() (or set dso->binary_type at least) first like the
> dwarf unwind code does.

hum, I dont see the need for this, but I haven't checked your
patchset for the multithread support yet ;-)

anyway, I dont mind tp straighten up the interface:

Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/