Re: [PATCH v2] staging: comedi: drivers: addi_apci_3501: Removed variables that is never used

[Ian Abbott]

On 30/01/15 12:10, Dan Carpenter wrote:
> On Fri, Jan 30, 2015 at 10:29:44AM +0000, Ian Abbott wrote:
> > > @@ -285,7 +284,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
> > >   	ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);
> > >   	ul_Command1 = ((ul_Command1 & 0xFFFFF9FDul) | 1 << 1);
> > >   	outl(ul_Command1, dev->iobase + APCI3501_TIMER_CTRL_REG);
> > > -	i_temp = inl(dev->iobase + APCI3501_TIMER_STATUS_REG) & 0x1;
> > > +	inl(dev->iobase + APCI3501_TIMER_STATUS_REG);
> > >
> > >   	return IRQ_HANDLED;
> > >   }
> >
> > Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>
>
> Ian, is the inl() really needed?  Richard did the conservative thing,
> but if we knew we could delete the inl() that would be nice.

I'm not sure if it's really needed, but it is part of some watchdog 
functionality, so I thought it best to leave it alone.

Hartley might know if it's needed.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/