Re: [PATCH] devfreq: Fix build break of devfreq-event class

From: MyungJoo Ham
Date: Fri Jan 30 2015 - 04:09:19 EST


On Fri, Jan 30, 2015 at 1:54 PM, Chanwoo Choi <cw00.choi@xxxxxxxxxxx> wrote:
> This patch fixes the build break of the exynos-ppmu driver because Makefile
> in drivers/devfreq don't include the entry of devfreq-event.c driver.
>
> The original patch[1] includes the entry to build devfreq-event.c without
> the build break. This build break is generated in the process of merging the
> patch.
> [1] https://lkml.org/lkml/2015/1/25/579
> - [PATCH v10 1/7] devfreq: event: Add new devfreq_event class to provide basic
> data for devfreq governor

Sorry, that one is already included in the for-rafael tree with
tags/pull_req_20150129. :)


>
> CC init/version.o
> LD init/built-in.o
> drivers/built-in.o: In function `exynos_ppmu_probe':
> binder.c:(.text+0x4447ec): undefined reference to `devm_devfreq_event_add_edev'
> make: *** [vmlinux] Error 1
>
> Cc: Rafael J. Wysocki <rjw@xxxxxxxxxxxxx>
> Cc: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>
> Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> ---
> drivers/devfreq/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/devfreq/Makefile b/drivers/devfreq/Makefile
> index 9256c35..5134f9e 100644
> --- a/drivers/devfreq/Makefile
> +++ b/drivers/devfreq/Makefile
> @@ -1,4 +1,5 @@
> obj-$(CONFIG_PM_DEVFREQ) += devfreq.o
> +obj-$(CONFIG_PM_DEVFREQ_EVENT) += devfreq-event.o
> obj-$(CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND) += governor_simpleondemand.o
> obj-$(CONFIG_DEVFREQ_GOV_PERFORMANCE) += governor_performance.o
> obj-$(CONFIG_DEVFREQ_GOV_POWERSAVE) += governor_powersave.o
> --
> 1.8.5.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html



--
MyungJoo Ham, Ph.D.
Frontier CS Lab, S/W Center, Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/