Re: [PATCH] mmc: Add hardware dependencies for sdhci-pxav3 and sdhci-pxav2

From: Jean Delvare
Date: Thu Jan 29 2015 - 10:56:35 EST


Hi Ulf,

On Wed, 28 Jan 2015 15:04:24 +0100, Ulf Hansson wrote:
> On 27 January 2015 at 15:34, Jean Delvare <jdelvare@xxxxxxx> wrote:
> > Hi Ulf,
> >
> > Le Tuesday 27 January 2015 Ã 15:06 +0100, Ulf Hansson a Ãcrit :
> >> On 26 January 2015 at 11:23, Jean Delvare <jdelvare@xxxxxxx> wrote:
> >> > I seem to understand that the sdhci-pxav3 and sdhci-pxav2 drivers are
> >> > only needed on the MMP architecture. So add a hardware dependency on
> >> > ARCH_MMP, so that other users don't get to build useless drivers.
> >>
> >> I would rather see the default option to be N.
> >> Thus those configurations that needs this driver will have to select it.
> >
> > This is a different question. The purpose of my patch is that people
> > configuring kernels for systems which just can't have these controllers,
> > are not asked about this driver at all. Changing the default to N would
> > not achieve that.
>
> For those SOC that want these drivers, they should be able to select
> them from their defconfigs. So it will be an opt-in instead of opt-out
> policy, which I prefer. It also follows the other Kconfig options for
> mmc drivers.

As you wish. But that change would be a separate patch going on top of
mine, right? I'm not sure I understand what you expect from me at this
point, please clarify.

--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/