Re: [PATCH] staging: comedi: drivers: dt2814: Removed variables that is never used

[Ian Abbott]

On 29/01/15 12:52, Ian Abbott wrote:
> On 28/01/15 22:33, Rickard Strandqvist wrote:
> > Variable ar assigned a value that is never used.
> > I have also removed all the code that thereby serves no purpose.
> >
> > This was found using a static code analysis program called cppcheck
> >
> > Signed-off-by: Rickard Strandqvist
> > <rickard_strandqvist@xxxxxxxxxxxxxxxxxx>
> > ---
> >   drivers/staging/comedi/drivers/dt2814.c |   13 ++++---------
> >   1 file changed, 4 insertions(+), 9 deletions(-)
>
> Good, apart from the bad English!
>
> Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>

On second thoughts, I retract my 'Reviewed-by'. The patch actually 
serves to point out a glaring bug in the original code, in that it 
acquires data in the interrupt routine but just throws it all away!

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/