Re: [PATCH v2] lib/checksum.c: fix carry in csum_tcpudp_nofold

From: Karl Beldan
Date: Thu Jan 29 2015 - 03:56:13 EST


On Wed, Jan 28, 2015 at 10:32:49PM -0800, David Miller wrote:
> From: Karl Beldan <karl.beldan@xxxxxxxxx>
> Date: Wed, 28 Jan 2015 10:58:11 +0100
>
> > The carry from the 64->32bits folding was dropped, e.g with:
> > saddr=0xFFFFFFFF daddr=0xFF0000FF len=0xFFFF proto=0 sum=1,
> > csum_tcpudp_nofold returned 0 instead of 1.
> >
> > Signed-off-by: Karl Beldan <karl.beldan@xxxxxxxxxxxxxxxx>
>
> Applied, thanks.

Fengguang's robot reported I managed to break the build, this occurs
when using non-generic do_csum and generic csum_tcpudp_nofold.
I guess a v3 is irrelevant now, should I send another patch for the
build fix only ? Sorry for that.

Karl
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/