Re: [PATCH v3 5/5] usb: serial: implement CMSPAR for F81232

[Peter Hung]

Hello.

I had using "scripts/checkpatch.pl -f" to scan original f81232.c.
It reported with "quoted string split across lines", so I merge these
2 strings into 1 in patch 1/5. But it still warning with "line over 80 
character", so I had shorted string with this line.

I will refine my patch set again with more attention.
Thanks for your advice.

Sergei Shtylyov æ 2015/1/28 äå 08:31 åé:
> Hello.
>
> On 1/28/2015 8:58 AM, Peter Hung wrote:
>
> > This patch implement CMSPAR in set_termios,
> > and fix some warnning from checkpatch.pl
>
>      Please don't try to do 2 unrelated things in one patch.
>
> > Signed-off-by: Peter Hung <hpeter+linux_kernel@xxxxxxxxx>
> > ---
> >   drivers/usb/serial/f81232.c | 21 +++++++++++++++------
> >   1 file changed, 15 insertions(+), 6 deletions(-)
>
> > diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
> > index 11a236b..79592d6 100644
> > --- a/drivers/usb/serial/f81232.c
> > +++ b/drivers/usb/serial/f81232.c
> [...]
> > @@ -361,12 +361,21 @@ static void f81232_set_termios(struct tty_struct
> > *tty,
> >
> >
> >       if (cflag & PARENB) {
> > -        if (cflag & PARODD)
> > -            new_lcr |= UART_LCR_PARITY; /* odd */
> > -        else
> > -            new_lcr |= SERIAL_EVEN_PARITY; /* even */
> > +        if (cflag & CMSPAR) {
> > +            if (cflag & PARODD)
> > +                new_lcr |= (UART_LCR_PARITY | UART_LCR_SPAR);
> > +            else
> > +                new_lcr |= (SERIAL_EVEN_PARITY
> > +                            | UART_LCR_SPAR);
> > +        } else {
> > +            if (cflag & PARODD)
> > +                new_lcr |= UART_LCR_PARITY; /* odd */
> > +            else
> > +                new_lcr |= SERIAL_EVEN_PARITY; /* even */
> > +        }
> >       }
> >
> > +
>
>     Not needed at all.
>
> >       if (cflag & CSTOPB)
> >           new_lcr |= UART_LCR_STOP;
> >       else
> > @@ -445,7 +454,7 @@ static int f81232_open(struct tty_struct *tty,
> > struct usb_serial_port *port)
> >
> >       result = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL);
> >       if (result) {
> > -        dev_err(&port->dev, "failed submitting interrupt urb, error
> > %d\n",
> > +        dev_err(&port->dev, "failed submitting urb, error %d\n",
>
>     What are you fixing here?
>
> WBR, Sergei

--
With Best Regards,
Peter Hung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/