Re: [PATCH 1/3] MIPS: Add arch CDMM definitions and probing

From: James Hogan
Date: Wed Jan 28 2015 - 20:13:25 EST


Hi Maciej,

On Wednesday 28 January 2015 23:09:17 Maciej W. Rozycki wrote:
> On Tue, 27 Jan 2015, James Hogan wrote:
>
> > diff --git a/arch/mips/include/asm/cpu.h b/arch/mips/include/asm/cpu.h
> > index 33866fce4d63..2086372fa72a 100644
> > --- a/arch/mips/include/asm/cpu.h
> > +++ b/arch/mips/include/asm/cpu.h
> > @@ -370,6 +370,7 @@ enum cpu_type_enum {
> > #define MIPS_CPU_RIXIEX 0x200000000ull /* CPU has unique exception codes for {Read, Execute}-Inhibit exceptions */
> > #define MIPS_CPU_MAAR 0x400000000ull /* MAAR(I) registers are present */
> > #define MIPS_CPU_FRE 0x800000000ull /* FRE & UFE bits implemented */
> > +#define MIPS_CPU_CDMM 0x10000000000ll /* CPU has Common Device Memory Map */
>
> Is it a typo here: 0x10000000000ll vs 0x1000000000ull?

Yes, it would appear so. Well spotted!

Thanks
James

>
> Maciej
>

Attachment: signature.asc
Description: This is a digitally signed message part.