Re: [PATCH 3.12 140/176] gpio: sysfs: fix gpio device-attribute leak

From: Johan Hovold
Date: Wed Jan 28 2015 - 15:47:22 EST


On Wed, Jan 28, 2015 at 06:46:26PM +0100, Jiri Slaby wrote:
> On 01/28/2015, 05:10 PM, Johan Hovold wrote:
> > On Wed, Jan 28, 2015 at 03:29:30PM +0100, Jiri Slaby wrote:
> >> From: Johan Hovold <johan@xxxxxxxxxx>
> >>
> >> 3.12-stable review patch. If anyone has any objections, please let me know.
> >>
> >> ===============
> >>
> >> commit 0915e6feb38de8d3601819992a5bd050201a56fa upstream.
> >>
> >> The gpio device attributes were never destroyed when the gpio was
> >> unexported (or on export failures).
> >>
> >> Use device_create_with_groups() to create the default device attributes
> >> of the gpio class device. Note that this also fixes the
> >> attribute-creation race with userspace for these attributes.
> >>
> >> Remove contingent attributes in export error path and on unexport.
> >>
> >> Fixes: d8f388d8dc8d ("gpio: sysfs interface")
> >> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> >> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> >> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> >
> > There was a mistake in the 3.14 (and 3.12) backport. A fixed v2 backport
> > has been posted in this thread:
> >
> > https://marc.info/?l=linux-kernel&m=142241055931689&w=2
>
> But there is no thread. Could you repost?

Just hasn't shown up in the archives yet.

You can find it in the stable queue:

https://git.kernel.org/cgit/linux/kernel/git/stable/stable-queue.git/tree/queue-3.14/gpio-sysfs-fix-gpio-device-attribute-leak.patch

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/