Re: [PATCH v5 2/2] x86/xen: allow privcmd hypercalls to be preempted on 64-bit

From: Luis R. Rodriguez
Date: Tue Jan 27 2015 - 15:13:14 EST


On Tue, Jan 27, 2015 at 10:06:44AM +0000, David Vrabel wrote:
> On 27/01/15 08:35, Jan Beulich wrote:
> >>>> On 27.01.15 at 02:51, <mcgrof@xxxxxxxxxxxxxxxx> wrote:
> >
> > Even if David told you this would be acceptable, I have to question
> > an abstract model of fixing issues on only 64-bit kernels - this may
> > be acceptable for distro purposes, but seems hardly the right
> > approach for upstream. If 32-bit ones are to become deliberately
> > broken, the XEN config option should become dependent on !X86_32.
>
> I'd rather have something omitted (keeping the current behaviour) than
> something that has not been tested at all.
>
> Obviously it would be preferable to to fix both 32-bit and 64-bit x86
> (and ARM as well) but I'm not going to block an important bug fix for
> the majority use case (64-bit x86).

The hunk for 32-bit should indeed only go in once we get a Tested-by.
Please let me know if there is anything else needed for this patch.

Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/