Re: [PATCH v3 08/13] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

From: Sylvain Rochet
Date: Tue Jan 27 2015 - 05:08:38 EST


Hello Wenyou,

On Tue, Jan 27, 2015 at 01:58:20PM +0800, Wenyou Yang wrote:
>
> diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
> index 0377c0d..d967c31 100644
> --- a/arch/arm/mach-at91/pm.c
> +++ b/arch/arm/mach-at91/pm.c
> @@ -71,7 +71,7 @@ static int at91_pm_begin(suspend_state_t state)
> * Verify that all the clocks are correct before entering
> * slow-clock mode.
> */
> -static int at91_pm_verify_clocks(void)
> +static int at91_pm_verify_clocks(suspend_state_t state)
> {
> unsigned long scsr;
> int i;
> @@ (...)

Unused state argument, it was added in v2, this is just a trace of a
reverted v2 change not fully cleaned.


> + if (!at91_pm_verify_clocks(state))
> + goto error;

Ditto.


Sylvain
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/