Re: [PATCH] ethernet: fm10k: Actually drop 4 bits

From: Vick, Matthew
Date: Mon Jan 26 2015 - 11:58:22 EST


On 1/23/15, 4:50 PM, "Rasmus Villemoes" <linux@xxxxxxxxxxxxxxxxxx> wrote:

>On Sat, Jan 24 2015, "Vick, Matthew" <matthew.vick@xxxxxxxxx> wrote:
>
>> Good catch! I noticed this too and was getting a patch together to
>>address
>> this.
>>
>> The difference is that I was planning on not silently accepting an
>>invalid
>> VLAN ID to begin with and returning FM10K_ERR_PARAM if the VLAN was
>> invalid, which I think is a better approach for this situation. If it's
>> alright with you, I'll generate the patch shortly and credit you via
>>your
>> Reported-by.
>
>Sure, do what you think is best.
>
>Rasmus

Sounds good. I'll get the patch created and validated through Jeff's tree.

Cheers,
Matthew

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/