Re: [PATCH 2/5] tools lib api fs: Add tracefs mount helper functions

From: Steven Rostedt
Date: Mon Jan 26 2015 - 09:26:39 EST


On Mon, 26 Jan 2015 10:02:55 +0100
Jiri Olsa <jolsa@xxxxxxxxxx> wrote:

> > Note, WTF is perf checking the magic number for debugfs?? If events
> > move, even if its at the same path, this will break perf!
>
> good question.. it's there since 2009:
> f6bdafef2ab9 perf_counter: Add tracepoint support to perf list, perf stat
>
> I guess we didn't want anyone to trick us with fake tracepoints ;-)

But that would be a feature not a bug. I could imagine admins doing
this for some work around.

But can we nuke that check? I don't think it's very useful.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/