Re: [PATCH 3/3] x86, crash: Allocate enough low-mem when crashkernel=high

From: Joerg Roedel
Date: Mon Jan 26 2015 - 07:40:14 EST


On Mon, Jan 26, 2015 at 01:20:17PM +0100, Borislav Petkov wrote:
> On Mon, Jan 26, 2015 at 01:11:42PM +0100, Joerg Roedel wrote:
> > Or we solve it in user-space by some more cleverness in creating the
> > kernel command-line for crashkernel=high.
>
> I'd say, we should try to do as much as possible automatically.

Thats hard to do, without any information about the driver needs we only
have the amount of devices in the system to base any heuristic on.

> > But besides that, I think the first two patches of this set make sense
> > anyway. I understand that the third one is debatable.
>
> Right, but since they fix a real problem, maybe we should take them now
> until a better fix is done? Yes, no?

Yes. Given that we have no data about what would work on most
systems, we can only change the value to a number that fixes know
problems and then act on possible regressions caused by the change (and
that change is pretty easy to revert if needed).


Joerg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/