Re: [PATCH] net: Linn Ethernet Packet Sniffer driver

[Stathis Voukelatos]

On 23/01/15 18:12, James Hogan wrote:
> > diff --git a/drivers/net/pkt-sniffer/Kconfig 
> > b/drivers/net/pkt-sniffer/Kconfig
> > new file mode 100644
> > index 0000000..26b4f98
> > --- /dev/null
> > +++ b/drivers/net/pkt-sniffer/Kconfig
> > @@ -0,0 +1,23 @@
> > +menuconfig PKT_SNIFFER
> > +    tristate "Linn packet sniffer support"
> Should the kconfig symbol have linn in the name, or should the prompt
> not have lin in the name?

No it should not actually, as this option enables the core (framework) 
driver.
Anybody could add a backend using the framework. Will change the text.

> > +
> > +config PKT_SNIFFER_ETHER
> > +    tristate "Ethernet packet sniffer"
> > +    depends on MIPS
> worth adding || COMPILE_TEST to get compile coverage on x86 allmodconfig
> builds, or does it have hard dependencies on the MIPS arch?

No hard dependencies on MIPS arch. Will change as you suggest.
Will implement your other recommendations too in the next version
of the patchset.

Thank you,
Stathis

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/