Re: Backport of spi-fsl-spi bugfix to 3.14.y

From: Mark Brown
Date: Sun Jan 25 2015 - 15:13:13 EST


On Sun, Jan 25, 2015 at 09:38:53AM -0800, Greg Kroah-Hartman wrote:
> On Fri, Jan 23, 2015 at 12:45:29PM +0000, Mark Brown wrote:

> > So, I now see this has actually been merged into stable without getting
> > to the bottom of why it's helping anything... this is a bit worrying
> > since it's adding new functionality and not really a bug fix. It'd have
> > been good to at least get a followup here.

> Do you want me to revert something from the stable tree? If so, has it
> also been reverted upstream?

The patch just isn't an obvious -stable patch - it's adding new
functionality, not fixing a bug, and I was surprised to discover it had
been added as a result. It's fine as new functionality and therefore
hasn't been reverted upstream.

We can probably leave it there, though if this is OK that's a bit of a
change, but if this new functionality is a good fix then we're probably
leaving other systems unfixed which isn't good, I would be very much
happier if we understood what had changed here. If new functionality is
OK there's a probably a bunch of other changes we should be pulling
back.

Attachment: signature.asc
Description: Digital signature