Re: [PATCH] Staging: dgnc: dgnc_cls.h: fixed four coding style warnings

From: Dan Carpenter
Date: Sat Jan 24 2015 - 04:30:17 EST


On Sat, Jan 24, 2015 at 10:49:08AM +0530, Sakshi Bansal wrote:
> Fixed 80 line warning in the code comments.
>
> Signed-off-by: Sakshi Bansal <sakshi.april5@xxxxxxxxx>
> ---
> drivers/staging/dgnc/dgnc_cls.h | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_cls.h b/drivers/staging/dgnc/dgnc_cls.h
> index 465d79a..7444b00 100644
> --- a/drivers/staging/dgnc/dgnc_cls.h
> +++ b/drivers/staging/dgnc/dgnc_cls.h
> @@ -38,7 +38,8 @@
> struct cls_uart_struct {
> u8 txrx; /* WR RHR/THR - Holding Reg */
> u8 ier; /* WR IER - Interrupt Enable Reg */
> - u8 isr_fcr; /* WR ISR/FCR - Interrupt Status Reg/Fifo Control Reg */
> + u8 isr_fcr; /* WR ISR/FCR - Interrupt Status Reg/Fifo
> + Control Reg */

These aren't correct kernel style. To be honest the original looks fine
with me. (No one cares about checkpatch except if it makes the code
better for human beings).

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/