Re: [PATCH V6 01/18] x86: Make page cache mode a real type

From: Thomas Gleixner
Date: Thu Jan 22 2015 - 06:07:28 EST


On Thu, 22 Jan 2015, Juergen Gross wrote:
> On 01/22/2015 08:11 AM, Steven Noonan wrote:
> > I notice these two symbols are exported GPL-only. This breaks builds
> > of several out-of-tree non-GPL modules such as the NVIDIA driver, and
> > VMware modules, etc. What is the appropriate code path for proprietary
> > modules to use when setting page cache mode flags? Alternatively, is
> > it possible for these EXPORT_SYMBOL_GPLs to be changed to
> > EXPORT_SYMBOL?
>
> I don't mind you sending a patch to change this. I won't object such a
> patch. OTOH this is more kind of a political question and I don't want
> to spend my time on arguing.

It's rather simple. If the new cache stuff replaces code which was
available under EXPORT_SYMBOL, we either need a compat export or make
the new exports non GPL.

Not that I like it, but that has been the policy so far. We only break
out of tree stuff if the export is broken or security relevant, like
we did with the init_mm export a few years ago.

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/