Re: [PATCH v2 4/4] leds: no longer use unnamed gpios

From: Olliver Schinagl
Date: Thu Jan 22 2015 - 04:38:00 EST


Hey Rojhalat,

On 22-01-15 10:32, Rojhalat Ibrahim wrote:
On Wednesday 21 January 2015 22:33:48 Olliver Schinagl wrote:
From: Olliver Schinagl <oliver@xxxxxxxxxxx>

The gpio document says we should not use unnamed bindings for gpios.
This patch uses the 'led-' prefix to the gpios and updates code and
documents. Because the devm_get_gpiod_from_child() falls back to using
old-style unnamed gpios, we can update the code first, and update
dts files as time allows.

Signed-off-by: Olliver Schinagl <oliver@xxxxxxxxxxx>
Where does devm_get_gpiod_from_child() fall back "to using old-style
unnamed gpios"?
Your absolutly right, I accidentally forgot a patch that was supposed to get squashed into this patchset. The idea is to do the same as in gpio-keys-polled.c. I'll make sure it sits in v3 of the set! My appologies!

Olliver

After applying this patch the leds defined in my devicetree do not
work anymore.

Rojhalat




--
Met vriendelijke groeten, Kind regards, ääåçéå

Olliver Schinagl
Research & Development
Ultimaker B.V.
http://www.ultimaker.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/