Re: [PATCH] Added PIDs for Actisense USB Devices

From: Johan Hovold
Date: Mon Jan 19 2015 - 10:14:07 EST


On Thu, Jan 15, 2015 at 08:34:34AM +0000, Mark Glover wrote:
> From: Mark Glover <mark@xxxxxxxxxxxxx>
>
> Signed-off-by: Mark Glover <mark@xxxxxxxxxxxxx>

Thanks for the patch and for addressing Peter's comments.

A couple of minor nits: Please use a subsystem prefix for your patch
summary, for example:

"USB: ftdi_sio: add PIDs for Actisense devices"

You should also include a commit message (e.g. your current subject)
even if this is a simple patch.

You are adding both Actisense and Chetco product ids. How are these
related? Shouldn't the Chetco be under it's own heading (and be
mentioned in the commit log)?

And when resending, please include a "PATCH v4" prefix to make it easy
to track patch revisions.

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/