Re: [patch 17/23] x86/smpboot: Cleanup ioapic handling

From: Borislav Petkov
Date: Fri Jan 16 2015 - 14:03:11 EST


On Thu, Jan 15, 2015 at 09:22:35PM -0000, Thomas Gleixner wrote:
> smpboot is very creative with the ways to disable ioapic.
>
> smpboot_clear_io_apic() smpboot_clear_io_apic_irqs() and
> disable_ioapic_support() serve a similar purpose.
>
> smpboot_clear_io_apic_irqs() is the most useless of all
> functions as it clears a variable which has not been setup yet.

Useful stuff that.

> Aside of that it has the same ifdef mess and conditionals around the
> ioapic related code, which can now be removed.
>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

Vehemently-Acked-by: Borislav Petkov <bp@xxxxxxx>

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/