Re: [PATCH v9 1/4] drm/i2c: tda998x: Add DT support for audio

From: Mark Brown
Date: Wed Jan 07 2015 - 12:34:23 EST


On Wed, Jan 07, 2015 at 05:18:20PM +0000, Andrew Jackson wrote:

> I understand your difficulty! I was just wanting something to clarify the
> meaning of the value without reference to the driver source.

> You could add something like this to your existing explanation: "The value
> describes which audio input pins are selected; this varies depending
> on chip type so consult the section on audio port configuration in the
> relevant datasheet.".

This is commonly done by just saying that the value will be written into
a given bitfield for such and such a purpose and then relying on the
chip documentation for that; it's a more direct way of saying the above.

Attachment: signature.asc
Description: Digital signature