Re: [PATCH 0/5] *** SUBJECT HERE ***

From: Paul Bolle
Date: Mon Jan 05 2015 - 17:19:01 EST


On Sun, 2015-01-04 at 02:41 +0100, Konrad Zapalowicz wrote:
> git send-email does one thing and one thing only - sends stuff via
> email. I do not see why it should parse the emails and decide whether to
> complete the operation or break based on what is in the emails.

It already has to parse the file(s) it's provided with. Perhaps it
already has checks to validate Subject: lines. Would an extra test be a
burden?

> It could
> warn though however since the cover letter is a product of different
> command introducing this logic would tightly couple those which is not
> good.

A warning would be too late: the message with the silly subject would be
already sent out.

> I guess that it is better that people who send stuff acctually care what
> they are sending. I mean that pretty quickly you learn to send the
> series of patches first to yourself and review before it goes out to the
> public.

It's good if people are careful. It's also good if programs help to
avoid silly mistakes.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/