Re: [RFC PATCH 0/4] kstrdup optimization

From: Andi Kleen
Date: Tue Dec 30 2014 - 16:29:22 EST


> This symmetry issue probably could be cleanly avoided only
> by having kfree() itself contain such an identifying check, as you suggest
> (thereby slowing down kfree() performance).

It actually shouldn't slow it down. kfree already complains if you free
a non slab page, this could be just in front of the error check.

The bigger concern is that it may hide some programing errors elsewhere
though. So it's probably better to keep it a separate function.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/