Re: [PATCH] openvswitch: fix odd_ptr_err.cocci warnings

From: David Miller
Date: Wed Dec 24 2014 - 15:18:41 EST


From: Pravin Shelar <pshelar@xxxxxxxxxx>
Date: Wed, 24 Dec 2014 10:49:22 -0800

> On Tue, Dec 23, 2014 at 10:41 PM, kbuild test robot
> <fengguang.wu@xxxxxxxxx> wrote:
>> net/openvswitch/vport-gre.c:188:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 189
>>
>> PTR_ERR should access the value just tested by IS_ERR
>>
>> Semantic patch information:
>> There can be false positives in the patch case, where it is the call
>> IS_ERR that is wrong.
>>
>> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
>>
>> CC: Pravin B Shelar <pshelar@xxxxxxxxxx>
>> Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
>
> Thanks for the fix.
>
> Acked-by: Pravin B Shelar <pshelar@xxxxxxxxxx>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/