Re: [PATCH v2 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY.

[Yunzhi Li]

Hi Romain :

On 2014/12/5 21:38, Romain Perier wrote:
> Hi,
>
> Some quick comments
>
> 2014-12-05 13:52 GMT+01:00 Yunzhi Li <lyz@xxxxxxxxxxxxxx>:
> > [...]
> >
> > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> > index ccad880..e3a5857 100644
> > --- a/drivers/phy/Kconfig
> > +++ b/drivers/phy/Kconfig
> > @@ -239,6 +239,13 @@ config PHY_QCOM_IPQ806X_SATA
> >          depends on OF
> >          select GENERIC_PHY
> >
> > +config PHY_ROCKCHIP_RK3288_USB2
> > +       tristate "Rockchip USB2 RK3288 PHY Driver"
> > +       depends on ARCH_ROCKCHIP && OF
> > +       select GENERIC_PHY
> > +       help
> > +         Enable this to support the Rockchip USB 2.0 PHY.
> > +
>
> The C module is named phy-rockchip-usb.c, why did you call the config
> entry PHY_ROCKCHIP_RK3288_USB2 ? why RK3288 ? this driver might be
> ported to old SoCs later.
> I think that PHY_ROCKCHIP_USB would be enough.
Right, this driver will be ported to old SoCs like RK3188 or RK3066, 
this will be renamed to PHY_ROCKCHIP_USB in the next version.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/