Re: [PATCH 0/3] /dev/mem as optional device + associated tidy up

From: Arnd Bergmann
Date: Sun Dec 07 2014 - 14:35:42 EST


On Sunday 07 December 2014 15:40:32 robert.ward114@xxxxxxxxxxxxxx wrote:
> From: Rob Ward <robert.ward114@xxxxxxxxxxxxxx>
>
> Makes the /dev/mem device optional using the CONFIG_DEVMEM option.
>
> This brings /dev/mem in line with /dev/kmem so it can de disabled.
> Disabling /dev/mem is preferable on devices that do not require
> direct access to memory in order to improve security. This is especially
> true on platforms where no restiction is placed on the areas of memory
> that can be accessed(for example mips) without custom modifcations to
> the kernel source.
>
> The implementation of this functionality declares the mem_fops structure
> as __maybe_unused to eliminate the need for #ifdefs throughout the
> file.
>
> Follow up changes are present to change CONFIG_DEVKMEM and CONFIG_DEVPORT
> to use __maybe_unused. This simplifies the code and make the
> implementations consistent.
>

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/