Re: [RESEND PATCHv2] drivers/rtc/rtc-snvs: Add clock support

From: Andrew Morton
Date: Fri Dec 05 2014 - 16:45:00 EST


On Fri, 05 Dec 2014 15:54:15 +0100 Stefan Agner <stefan@xxxxxxxx> wrote:

> It can be fixed, with something like this:
>
> @@ -346,7 +347,10 @@ static int snvs_rtc_resume(struct device *dev)
> }
> #endif
>
> -static SIMPLE_DEV_PM_OPS(snvs_rtc_pm_ops, snvs_rtc_suspend,
> snvs_rtc_resume);
> +static const struct dev_pm_ops snvs_rtc_pm_ops = {
> + .suspend_noirq = snvs_rtc_suspend,
> + .resume_noirq = snvs_rtc_resume,
> +};
>
> static const struct of_device_id snvs_dt_ids[] = {
> { .compatible = "fsl,sec-v4.0-mon-rtc-lp", },
>
>
>
> Andrew, this patch is already merged, so it would need another fix for
> this, right?

A replacement patch is OK. An incremental patch is OK too. I almost
always turn the replacement into an incremental so that I and others
can see what changed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/