Re: [PATCH 2/2] ftracetest: Add --verbose option for showing echo output

From: Namhyung Kim
Date: Fri Dec 05 2014 - 00:52:54 EST


On Fri, Dec 05, 2014 at 02:23:23PM +0900, Masami Hiramatsu wrote:
> (2014/12/05 14:08), Namhyung Kim wrote:
> > On Thu, Dec 04, 2014 at 02:41:23PM -0500, Masami Hiramatsu wrote:
> >> Add --verbose/-v option for showing echo output in testcases.
> >> This is good for checking the progress of testcases which
> >> take a longer time to run.
> >>
> >> To implement this feature, all the testcase failures are
> >> captured in ftracetest and send signal to set SIG_RESULT=FAIL.
> >>
> >> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>
> >> ---
> >
> > [SNIP]
> >> - # setup PID and PPID, $$ is not updated.
> >> - (cd $TRACING_DIR; read PID _ < /proc/self/stat ;
> >> - set -e; set -x; . $1) >> $testlog 2>&1
> >> - eval_result $? $SIG_RESULT
> >> + if [ $VERBOSE -ne 0 ]; then
> >> + __run_test $1 2>> $testlog | tee -a $testlog
> >
> > Shouldn't it be
> >
> > __run_test $1 2>&1 | tee -a $testlog
> >
> > ?
>
> No, that outputs both stdout and stderr to $testlog and console.
> What I'd like to do above is only stdout to $testlog and console and
> stderr goes only to $testlog. (Note that __run_test set -x which outputs
> every executed command to stderr)

Hmm.. so the actual output of the failing command is not shown on
console even when -v option is given, right?

Anyway I worried about that the order of messages might be mixed..

echo msg1 > /dev/stdout
echo msg2 > /dev/stderr
echo msg3 > /dev/stdout
echo msg4 > /dev/stderr

So the output in this case can be like msg2, msg4, msg1, and msg3..?

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/