Re: [PATCH v7 08/11] arm/arm64: Unexport restart handlers

[Guenter Roeck]

On 12/04/2014 05:36 AM, Geert Uytterhoeven wrote:
> Hi GÃnther,
>
> On Wed, Aug 20, 2014 at 2:45 AM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> > Implementing a restart handler in a module don't make sense
> > as there would be no guarantee that the module is loaded when
> > a restart is needed. Unexport arm_pm_restart to ensure that
> > no one gets the idea to do it anyway.
>
> Why not? I was just going to do that, but I got greeted by:

Because you should register a restart handler instead, like the other
drivers in the same directory now do.

> ERROR: "arm_pm_restart" [drivers/power/reset/rmobile-reset.ko] undefined!
>
> So now we have to make sure all reset drivers for a zillion different
> hardware devices are builtin, and can't be modular?
No. All those drivers need to do is to register a restart handler using
the API provided in the patch series.

Ultimately all restart handlers should do that and arm_pm_restart should
go away entirely. That was the point of the patch series.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/