Re: [PATCH 02/35] UBI: Fix stale pointers in ubi->lookuptbl

[Tanya Brokhman]

On 12/4/2014 1:04 PM, Richard Weinberger wrote:
> Tanya,
>
> Am 04.12.2014 um 12:00 schrieb Tanya Brokhman:
> > Hi Richard
> >
> > On 10/29/2014 2:45 PM, Richard Weinberger wrote:
> > > In some error paths the WL sub-system gives up on a PEB
> > > and frees it's ubi_wl_entry struct but does not set
> > > the entry in ubi->lookuptbl to NULL.
> > > Fastmap can stumble over such a stale pointer as it uses
> > > ubi->lookuptbl to find all PEBs.
> > >
> > > Fix this by setting the pointers to free'd ubi_wl_entry to NULL.
> >
> > There are 2 more places:
> > tree_destroy() and protection_queue_destroy() where ubi_wl_entry is released. Both functions used on power down so all should be good as is, just wanted to make sure you didn't add
> > ubi->lookuptbl[e2->pnum] = NULL there on purpose.
>
> I fear you're looking at the old patch series.
> Please have a look at:
> "[PATCH 3/6] UBI: Fix stale pointers in ubi->lookuptbl" sent on 30.11.2014.
>
> Thanks,
> //richard

oh, you're right. Started from the oldest. now I see you released v2. 
Sorry. So I should be looking at "Fastmap update v2 (pile 1-7)", right?

Thanks,
Tanya Brokhman
--
Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/