Re: [PATCH] optimize ktime_divns for constant divisors

From: Robert Jarzmik
Date: Wed Dec 03 2014 - 15:16:39 EST


Nicolas Pitre <nicolas.pitre@xxxxxxxxxx> writes:

> Let ktime_divns() use do_div() inline whenever the divisor is constant
> and small enough. This will make things like ktime_to_us() and
> ktime_to_ms() much faster.

Hi Nicolas,

I suppose the "small enough" is linked to the "!(div >> 32)" in your patch. Can
I have the rationale which brought up this value, and if that value is universal
across architectures (ie. x86/ppc/arm/...) ?

And when you say "much faster", do you have figures to add to your commit
message ?

Cheers.

--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/