Re: [PATCH 3/3] ftracetests: Add test to test event filter logic

[Alexei Starovoitov]

On Wed, Dec 3, 2014 at 12:40 AM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> On Tue, 2 Dec 2014 22:22:16 -0800
> Alexei Starovoitov <ast@xxxxxxxxxxxx> wrote:
>
>> On Tue, Dec 2, 2014 at 7:13 PM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>> > From: "Steven Rostedt (Red Hat)" <rostedt@xxxxxxxxxxx>
>> >
>> > Add a test to test the event filter logic. It currently tests the
>> > following filters against sched:sched_switch event.
>> >
>> >    ( prev_pid != 0 )
>> >    ( prev_pid == 0 )
>> >    ( prev_pid < 100 )
>> >    ( prev_pid <= $$ )
>> >    ( prev_pid > 100 )
>> >    ( prev_pid >= $$ )
>> >   ! ( prev_pid != 0 )
>> >   ! ( prev_pid == 0 )
>> >   ! ( prev_pid < 100 )
>> >   ! ( prev_pid <= $$ )
>> >   ! ( prev_pid > 100 )
>> >   ! ( prev_pid >= $$ )
>> >    ( prev_pid != 0 && next_pid > 10 )
>> >    ( prev_pid != 0 || next_pid > 10 )
>> >   ! ( prev_pid != 0 && next_pid > 10 )
>> >   ! ( prev_pid != 0 || next_pid > 10 )
>> >    ( prev_pid & 1 )
>> >    ( prev_pid & 2 )
>> >    ( prev_pid & 4 )
>> >    ( prev_pid & 8 )
>> >    ( prev_pid & 16 )
>> >   ! ( prev_pid & 1 )
>> >   ! ( prev_pid & 2 )
>> >   ! ( prev_pid & 4 )
>> >   ! ( prev_pid & 8 )
>> >   ! ( prev_pid & 16 )
>> >    ( next_comm ~ "ftrace-test-fil" )
>> >    ( next_comm != "ftrace-test-fil" )
>> >   ! ( next_comm ~ "ftrace-test-fil" )
>> >   ! ( next_comm != "ftrace-test-fil" )
>>
>> thanks for the tests!
>> Since you're adding full support for 'not',
>> I think would be good to have few more tests
>> where ! is not a top node. Like:
>> (prev_pid != 0 && !(next_pid & 2))
>> and another one with ! at multiple levels, like:
>> (prev_pid != 0 && !(next_pid != 2 && !(prev_pid > 3)))
>> ... or reject them during parsing.
>
> Sure, would you like to add them :-)
>
> I spent more time on this than I should have. I have other things to
> work on and this little project has already put me behind on my other
> tasks.

aren't we all starting to hack things only to realize
that the scope of work is too large? ;)
Anyway, will try to add these tests when your patches land.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/