Re: [PATCH 5/5] ASoC: dwc: Ensure FIFOs are flushed to prevent channel swap

From: Mark Brown
Date: Wed Dec 03 2014 - 12:39:20 EST


On Wed, Dec 03, 2014 at 04:39:14PM +0000, Andrew Jackson wrote:
> If the FIFOs aren't flushed, the left/right channels may be swapped:
> this may occur if the FIFOs are not empty when the streams start.

> /* Iterate over set of channels - independently controlled. */
> do {
> if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
> + i2s_write_reg(dev->i2s_base, TXFFR, 1);

This is an example of the problem with putting fixes at the end of the
series - this can't be applied without your previous change to add the
support for more channels (which is a new feature).

Attachment: signature.asc
Description: Digital signature