Re: [RFC 5/5] i2c: omap: add trace

From: Felipe Balbi
Date: Wed Dec 03 2014 - 09:55:48 EST


On Wed, Dec 03, 2014 at 05:52:18PM +0300, Alexander Kochetkov wrote:
>
> 03 ÐÐÐ. 2014 Ð., Ð 17:49, Felipe Balbi <balbi@xxxxxx> ÐÐÐÐÑÐÐ(Ð):
>
> > NAK, if you want to add traces, use, well, tracepoints :-) It makes no
> > sense to hack stuff like this.
>
> It's for testing only the problem reported not for upstream :)
> The hack stuff like this is to allow for me to see what happens on the Tony's board.
> I don't have omap2430 board.

oh alright, you might want to make it clear by adding "not for merging"
somewhere in the patch. Also, tracepoints would be something that can be
merged upstream *and* can be used for testing when necessary.

--
balbi

Attachment: signature.asc
Description: Digital signature