Re: [PATCH v15 06/12] dt-bindings: add document for dw_hdmi

[Andy Yan]

Hi Philipp:
On 2014å12æ03æ 02:23, Philipp Zabel wrote:
> Hi Andy,
>
> Am Dienstag, den 02.12.2014, 15:42 +0800 schrieb Andy Yan:
> > diff --git a/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt b/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt
> > new file mode 100644
> > index 0000000..107c1ca
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt
> > @@ -0,0 +1,40 @@
> > +DesignWare HDMI bridge bindings
> > +
> > +Required properities:
> > +- compatible: platform specific such as:
> > +   * "fsl,imx6q-hdmi"
> > +   * "fsl,imx6dl-hdmi"
> > +   * "rockchip,rk3288-dw-hdmi"
> I think we should add a common compatible value "snps,dw-hdmi-tx" here:
>
> 	compatible = "fsl,imx6q-hdmi", "snps,dw-hdmi-tx";
     How about "snps,dw-hdmi", because the driver is not only about
  hdmi tx, but also include hdmi phy.
      If we add such compatible value, do we have to implement another
   platform driver like dw_hdmi-pltfm.c with the 
compatible="snps,dw-hdmi" ,
   or just include the compatible value in dw_hdmi-imx.c and 
dw_hdmi-rockchip.c?
> > +- reg: Physical base address and length of the controller's registers.
> > +- ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing
> Better make ddc-i2c-bus optional, see the other thread about the ddc i2c
> master.
>
> > +- interrupts: The HDMI interrupt number
> > +
> > +Optional properties
> > +- reg-io-width: the width of the reg:1,4, default set to 1 if not present
> > +
> > +Example:
> > +	hdmi: hdmi@0120000 {
> > +		compatible = "fsl,imx6q-hdmi";
> > +		reg = <0x00120000 0x9000>;
> > +		interrupts = <0 115 0x04>;
> > +		gpr = <&gpr>;
> > +		clocks = <&clks 123>, <&clks 124>;
> > +		clock-names = "iahb", "isfr";
> > +		ddc-i2c-bus = <&i2c2>;
> > +
> > +		port@0 {
> > +			reg = <0>;
> > +
> > +			hdmi_mux_0: endpoint {
> > +				remote-endpoint = <&ipu1_di0_hdmi>;
> > +			};
> > +		};
> > +
> > +		port@1 {
> > +			reg = <1>;
> > +
> > +			hdmi_mux_1: endpoint {
> > +				remote-endpoint = <&ipu1_di1_hdmi>;
> > +			};
> > +		};
> > +	};
> regards
> Philipp
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-rockchip


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/