[PATCH 1/2] ALSA: ctxfi: Deletion of an unnecessary check before the function call "kfree"

From: SF Markus Elfring
Date: Tue Dec 02 2014 - 15:55:33 EST


From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 2 Dec 2014 20:00:33 +0100

The kfree() function performs also input parameter validation.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
---
sound/pci/ctxfi/ctdaio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/ctxfi/ctdaio.c b/sound/pci/ctxfi/ctdaio.c
index c1c3f88..1712332 100644
--- a/sound/pci/ctxfi/ctdaio.c
+++ b/sound/pci/ctxfi/ctdaio.c
@@ -577,7 +577,7 @@ static int get_daio_rsc(struct daio_mgr *mgr,
error:
if (dao)
kfree(dao);
- else if (dai)
+ else
kfree(dai);

spin_lock_irqsave(&mgr->mgr_lock, flags);
--
2.1.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/