Re: [RESEND PATCH nouveau 2/3] volt: allow non-bios voltage scaling

From: Martin Peres
Date: Mon Dec 01 2014 - 17:58:00 EST


On 29/11/2014 09:22, Alexandre Courbot wrote:
On Fri, Nov 28, 2014 at 8:12 PM, Vince Hsu <vinceh@xxxxxxxxxx> wrote:
Signed-off-by: Vince Hsu <vinceh@xxxxxxxxxx>
Make sure you always write a short summary for your patches, even if
the title sounds sufficient.

I agree. Something like "Move the vbios parsing out of init() and
call it conditionally if the platform has a vbios. Non-vbios platforms
can use the ctor() to init the data structures.".

At the very least this patch makes the code easier to read, so:

Acked-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
Acked-by: Martin Peres <martin.peres@xxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/